Update mermaid template #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mermaid template in the schema command wasn't showing relationship actions for resources and showed one-to-many relationships between resources. Technically, we don't keep track of constraints on number of relationships, so to reflect that in the ER diagram this commit updates the edges between nodes to reflect that. It also adds related actions to union types. Signed-off-by: John Schaeffer <[email protected]>
This commit renames "perm" to "action" in the mermaid template to make the intent of the attribute a little clearer to consumers. Signed-off-by: John Schaeffer <[email protected]>
mikemrm
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some light fixes to the mermaid template we have for generating graphs based on the schema.
It looks like this when rendered with the default (test) policy:
erDiagram role { id_prefix permrol } role }o--o{ subject : subject user { id_prefix idntusr } client { id_prefix idntcli } tenant { id_prefix tnntten } tenant }o--o{ tenant : parent loadbalancer { id_prefix loadbal action loadbalancer_get action loadbalancer_update action loadbalancer_delete owner_action loadbalancer_get owner_action loadbalancer_update owner_action loadbalancer_delete } loadbalancer }o--o{ resourceowner : owner subject { } subject ||--|| user : alias subject ||--|| client : alias resourceowner { action loadbalancer_create action loadbalancer_get action loadbalancer_update action loadbalancer_list action loadbalancer_delete parent_action loadbalancer_create parent_action loadbalancer_get parent_action loadbalancer_update parent_action loadbalancer_list parent_action loadbalancer_delete } resourceowner ||--|| tenant : alias