Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tracing for permissions checks #156

Merged
merged 5 commits into from
Aug 9, 2023
Merged

Improve tracing for permissions checks #156

merged 5 commits into from
Aug 9, 2023

Commits on Aug 9, 2023

  1. Enable OTLP for Jaeger, start using it 

    Signed-off-by: John Schaeffer <[email protected]>
    @jnschaeffer
    jnschaeffer committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    069a308 View commit details
    Browse the repository at this point in the history

  2. Provide better spans for allow/deny events 

    This commit updates permissions checks to provide better spans for
surfacing allow/deny events. In particular, it tries to enforce the
following conventions:

* Allow and deny are explicitly conveyed using permissions.outcome
* Denials are not errors

These two conventions combined help us differentiate between allows,
denials, and problems communicating with SpiceDB.

Signed-off-by: John Schaeffer <[email protected]>
    @jnschaeffer
    jnschaeffer committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    71d519a View commit details
    Browse the repository at this point in the history

  3. Fix bad SpiceDB PSK in dev container 

    Signed-off-by: John Schaeffer <[email protected]>
    @jnschaeffer
    jnschaeffer committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    fbda590 View commit details
    Browse the repository at this point in the history

  4. Remove spurious audience in OIDC config 

    Signed-off-by: John Schaeffer <[email protected]>
    @jnschaeffer
    jnschaeffer committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    ce93545 View commit details
    Browse the repository at this point in the history

  5. Fix linting issues 

    Signed-off-by: John Schaeffer <[email protected]>
    @jnschaeffer
    jnschaeffer committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    9273f12 View commit details
    Browse the repository at this point in the history