update to use new events handling #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemrm
force-pushed
the
update-events
branch
15 times, most recently
from
d6c75c9
to
aa05f1a
Compare
mikemrm
force-pushed
the
update-events
branch
4 times, most recently
from
b73d7c1
to
cf44346
Compare
jnschaeffer
requested changes
Aug 4, 2023
Signed-off-by: Mike Mason <[email protected]>
Signed-off-by: Mike Mason <[email protected]>
jnschaeffer
requested changes
Aug 7, 2023
There was a problem hiding this comment.
Mostly small changes. Error message formatting suggestions can be ignored if they're not useful.
More generally, I think we would benefit from getting into the habit of adding OpenTelemetry instrumentation whenever we define/update functions that cross system boundaries (network calls, DB calls, etc). I left a couple of comments where I believe we could gain the most from adding it but we can really add it in many more places.
Signed-off-by: Mike Mason <[email protected]>
Signed-off-by: Mike Mason <[email protected]>
jnschaeffer
approved these changes
Aug 7, 2023
| github.com/pkg/errors v0.9.1 | ||
| github.com/spf13/cobra v1.7.0 | ||
| github.com/spf13/pflag v1.0.5 | ||
| github.com/spf13/viper v1.16.0 | ||
| github.com/stretchr/testify v1.8.4 | ||
| go.infratographer.com/x v0.3.4 | ||
| go.infratographer.com/x v0.3.5-0.20230804152936-1fb9cfe07da6 |
There was a problem hiding this comment.
Are we going to be on this prerelease commit for everything until v0.3.5 is cut?
There was a problem hiding this comment.
we are for now, still waiting for the actual release to be cut.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to use the new x/events events package which removes the watermill format as well as implements the new AuthRelationshipRequest and Response events.