Get role resources #147
Merged
Get role resources #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Mason <[email protected]>
Signed-off-by: Mike Mason <[email protected]>
mikemrm
force-pushed
the
get-role-resources
branch
from
82e0bd6
to
bb5aaa0
Compare
jnschaeffer
requested changes
Jul 24, 2023
internal/query/relations.go
Outdated
Comment on lines
594
to
596
| if len(resActions) > 1 { | ||
| e.logger.Warnw("role is assigned to more than one resource", "role.id", roleResource.ID.String()) | ||
| } |
There was a problem hiding this comment.
IMO it'd probably be better for us to return an error here, since this is something that shouldn't happen.
internal/query/relations.go
Outdated
Comment on lines
632
to
634
| if len(resActions) > 1 { | ||
| e.logger.Warnw("role is assigned to more than one resource", "role.id", roleResource.ID.String()) | ||
| } |
Signed-off-by: Mike Mason <[email protected]>
jnschaeffer
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds endpoints to retrieve a role as well as retrieve a roles resource assignment.