Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support bulk checks #146

Merged
merged 5 commits into from
Jul 26, 2023
Merged

Support bulk checks #146

merged 5 commits into from
Jul 26, 2023

Commits on Jul 25, 2023

  1. add support for bulk permission check requests 

    Signed-off-by: Mike Mason <[email protected]>
    @mikemrm
    mikemrm committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    400833b View commit details
    Browse the repository at this point in the history

  2. split out checker code 

    Signed-off-by: Mike Mason <[email protected]>
    @mikemrm
    mikemrm committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    ade6fc1 View commit details
    Browse the repository at this point in the history

  3. add bulk permission checks to client 

    Signed-off-by: Mike Mason <[email protected]>
    @mikemrm
    mikemrm committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    030f958 View commit details
    Browse the repository at this point in the history

  4. correct lint issues 

    Signed-off-by: Mike Mason <[email protected]>
    @mikemrm
    mikemrm committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    aefb5ec View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. implement review suggestions 

    - Splits up the Request and Results
- Switch to using context.WithTimeout instead of time.After to ensure context is cancelled
- Replaces WaitGroup with looping through the known count and logging all errors

Signed-off-by: Mike Mason <[email protected]>
    @mikemrm
    mikemrm committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    db7b681 View commit details
    Browse the repository at this point in the history