Add permissions middleware #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Mason <[email protected]>
mikemrm
force-pushed
the
add-permissions-mdw
branch
from
dcfa6e1
to
6b495bc
Compare
fishnix
requested changes
Jun 22, 2023
pkg/permissions/permissions.go
Outdated
| func New(config Config, options ...Option) (*Permissions, error) { | ||
| p := &Permissions{ | ||
| enabled: config.URL != "", | ||
| client: http.DefaultClient, |
There was a problem hiding this comment.
let's use a sane client with a really short timeout instead of the default client
There was a problem hiding this comment.
(unless you think its better for implementers to pass a client - but that feels like a 🦶 🔫 )
mikemrm
force-pushed
the
add-permissions-mdw
branch
from
6b495bc
to
817fcc7
Compare
Produces an echo middleware which adds a checker function into the request context that is later used to check if the current actor has access to the requesting resource and action. Signed-off-by: Mike Mason <[email protected]>
mikemrm
force-pushed
the
add-permissions-mdw
branch
from
817fcc7
to
73c6bf6
Compare
fishnix
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Produces an echo middleware which adds a checker function into the
request context that is later used to check if the current actor has
access to the requesting resource and action.