Correct event relationships #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Mason <[email protected]>
Signed-off-by: Mike Mason <[email protected]>
Signed-off-by: Mike Mason <[email protected]>
Signed-off-by: Mike Mason <[email protected]>
We need to dig into the errors that may be produced and create a list of errors which should be reprocessable. Otherwise we might reprocess a message which will never be succeed, wasting resources. Signed-off-by: Mike Mason <[email protected]>
mikemrm
force-pushed
the
correct-event-relationships
branch
2 times, most recently
from
b748030
to
ded2de5
Compare
fishnix
previously approved these changes
Jun 21, 2023
internal/pubsub/subscriber.go
Outdated
Comment on lines
177
to
181
| rType := s.qe.GetResourceType(resource.Type) | ||
| if rType == nil { | ||
| s.logger.Warnw("no resource type found for", "resource_type", resource.Type) | ||
|
|
||
| return nil |
There was a problem hiding this comment.
just realized you can do this outside of the loop right?
There was a problem hiding this comment.
ah yes, good point. fixing
This allows for relations to be determined based on their type. All matched relations will be created. Signed-off-by: Mike Mason <[email protected]>
mikemrm
force-pushed
the
correct-event-relationships
branch
from
ded2de5
to
e7cdd25
Compare
fishnix
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were improperly building relationships setting the relation to the type of resource rather than the actual relation it had.
This now finds all the relations which are supported by the two resources and creates the appropriate relationships.