IAPL schema generation #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Schaeffer <[email protected]>
fishnix
reviewed
Jun 14, 2023
internal/iapl/policy.go
Outdated
| return &out | ||
| } | ||
|
|
||
| func (v *policy) validateTypeAliases() error { |
There was a problem hiding this comment.
check for a nil policy? here and below?
There was a problem hiding this comment.
In general I don't like to do nil checks for pointer receivers unless there's a legitimate reason they could be nil. In this case there isn't, so a panic would be the expected result for me if someone tried to call validateTypeAliases() on a nil policy.
Signed-off-by: John Schaeffer <[email protected]>
Signed-off-by: John Schaeffer <[email protected]>
Signed-off-by: John Schaeffer <[email protected]>
Signed-off-by: John Schaeffer <[email protected]>
Co-authored-by: E Camden Fisher <[email protected]> Signed-off-by: John Schaeffer <[email protected]>
Signed-off-by: John Schaeffer <[email protected]>
fishnix
reviewed
Jun 15, 2023
Signed-off-by: John Schaeffer <[email protected]>
mikemrm
reviewed
Jun 15, 2023
Signed-off-by: John Schaeffer <[email protected]>
Signed-off-by: John Schaeffer <[email protected]>
Signed-off-by: John Schaeffer <[email protected]>
Signed-off-by: John Schaeffer <[email protected]>
Signed-off-by: John Schaeffer <[email protected]>
Signed-off-by: John Schaeffer <[email protected]>
mikemrm
approved these changes
Jun 15, 2023
jnschaeffer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates permissions-api to use the Infratographer authorization policy language (final name TBD) as defined in this design document: https://gist.github.com/jnschaeffer/29df29ee3fc8aca905cafb45919e9843
The overall goal here is to move towards an external policy being provided to permissions-api, then modified with some resources like roles and subjects that permissions-api needs to do its job. Some work in that realm that is explicitly out of scope for this PR:
These items will be addressed in subsequent PRs.