add permission checks to api endpoints #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mikemrm
force-pushed
the
add-permissions-checks
branch
3 times, most recently
from
488518b
to
d0ad47f
Compare
jnschaeffer
requested changes
Feb 2, 2024
cmd/serve.go
Outdated
| @@ -72,6 +73,14 @@ func serve(ctx context.Context) { | |||
| defer auditCloseFn() //nolint:errcheck // Not needed to check returned error. | |||
| } | |||
|
|
|||
| perms, err := permissions.New(config.Config.Permissions, | |||
| permissions.WithLogger(logger), | |||
| permissions.WithDefaultChecker(permissions.DefaultAllowChecker), | |||
There was a problem hiding this comment.
We should probably make this configurable (with the default deny checker as the default).
There was a problem hiding this comment.
Indeed I see what you're saying. Let me see about adding this configuration into the permissions library as I think that would be a much needed improvement to that and simplify these downstream app integrations.
There was a problem hiding this comment.
I've created this ability in this PR for permissions-api: infratographer/permissions-api#217
There was a problem hiding this comment.
Sounds good! We can probably just remove this line then.
mikemrm
force-pushed
the
add-permissions-checks
branch
2 times, most recently
from
748f78d
to
4e6f2be
Compare
jnschaeffer
reviewed
Feb 7, 2024
This adds permission checks to api endpoints. The following permissions-api policy actions are now required: - iam_issuer_create - iam_issuer_update - iam_issuer_delete - iam_issuer_get - iam_oauthclient_create - iam_oauthclient_delete - iam_oauthclient_get Signed-off-by: Mike Mason <[email protected]>
mikemrm
force-pushed
the
add-permissions-checks
branch
from
4e6f2be
to
9c93101
Compare
jnschaeffer
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds permission checks to api endpoints.
The following permissions-api policy actions are now required: