Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension calculation is not perform when ressources are not evaluated #200

Closed
matthieupetite opened this issue Sep 13, 2023 · 4 comments · Fixed by #201
Closed

Extension calculation is not perform when ressources are not evaluated #200

matthieupetite opened this issue Sep 13, 2023 · 4 comments · Fixed by #201
Labels
bug Something isn't working

Comments

@matthieupetite
Copy link

When a resource is not evalutated, the Costs is set to NaN (or undefined) causing the sum to be also set to NaN, can it be changed to have a result calculation working.

Here is a screenshot showing the issue.

image

The extension version is v0.2.17
@aliscott aliscott added the bug Something isn't working label Sep 13, 2023
@aliscott
Copy link
Member

@matthieupetite thanks for reporting 🙏. This is on our current sprint to fix this issue.

@matthieupetite
Copy link
Author

Good news and thanks a lot

@hugorut hugorut mentioned this issue Sep 15, 2023
Closed
@hugorut
Copy link
Collaborator

hugorut commented Sep 15, 2023

another user reported a replicable example of this on an issue in the infracost/infracost repo, see: infracost/infracost#2662 (comment)

hugorut added a commit that referenced this issue Sep 27, 2023
@hugorut
fix: nan monthly cost
23a37b2 
fixes #200

Resolves issue where if monthlyCost was `undefined` we were mistakenly adding it to the cost total.
@hugorut hugorut mentioned this issue Sep 27, 2023
Merged
hugorut added a commit that referenced this issue Sep 27, 2023
@hugorut
fix: nan monthly cost (#201)
c8aaead 
* fix: nan monthly cost

fixes #200

Resolves issue where if monthlyCost was `undefined` we were mistakenly adding it to the cost total.

* chore: bump version
@hugorut
Copy link
Collaborator

hugorut commented Sep 27, 2023

Thanks for reporting @matthieupetite, this issue has been fixed in the v0.2.18 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: nan monthly cost infracost/vscode-infracost
3 participants
@aliscott @matthieupetite @hugorut