Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed race condition bug in OnEnd and added a unit test #1

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Fixed race condition bug in OnEnd and added a unit test #1

wants to merge 12 commits into from
+33 −3

Conversation

Kaushal28
Copy link

@Kaushal28 Kaushal28 commented Mar 30, 2023 •
edited
Loading

Fixed race condition bug in OnEnd by using Lock instead of RLock and added a unit test.

@Kaushal28 Kaushal28 changed the base branch from main to develop March 30, 2023 12:15
shubham-bansal96
shubham-bansal96 approved these changes Mar 31, 2023
View reviewed changes
Copy link

@shubham-bansal96 shubham-bansal96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kaushal28 and others added 2 commits March 31, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ApsTomar ApsTomar ApsTomar approved these changes

@shubham-bansal96 shubham-bansal96 shubham-bansal96 approved these changes

@samkulkarni20 samkulkarni20 Awaiting requested review from samkulkarni20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kaushal28 @ApsTomar @shubham-bansal96