OP-312 telemetry module #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added Telemetry popup + configuration renamed SmsSender class to SmsDaemon
dbmalkovsky
reviewed
Aug 26, 2021
dbmalkovsky
reviewed
Aug 26, 2021
dbmalkovsky
reviewed
Aug 26, 2021
|
I would suggest rebasing on the current develop branch. There are conflicts in this pr; for example database.properties, log4j.properties, and settings.properties do not exist any longer in develop. They now all end in |
goto-eof
force-pushed
the
OP-312-telemetry-module
branch
from
11bf28e to
6019e70
Compare
mwithi
reviewed
Sep 2, 2021
mwithi
reviewed
Sep 2, 2021
mwithi
reviewed
Sep 2, 2021
data collector module
goto-eof
force-pushed
the
OP-312-telemetry-module
branch
from
ed8ad7b to
ee1456e
Compare
- now telemetry is based on the following rules: if active = null => show telemetry popup, if active = true => start telemetry daemon, if active = false => do nothing (we should add a menu item in order to allow user to access to the popup?) - if TELEMETRYENABLED is yes then start telemetry daemon always (with SINGLEUSER equals to yes or no)
+ added also simulated message sending (when DEBUG=yes)
+ managed the case when telemetry module is disabled from settings.properties (could be used for other OH modules): we will not show the menu item in the Settings menu
…atici#877) * Set default duration (30min) and date check on visits. Also clean and improve code * Fix for multiple visit save * Fix as per comments review * Fix therapy changes and also refactor constants * Fix spacing * Fix edit therapy (not insert) Fix also duration calculation * Fix window position after re-pack * Add remove visit button in worksheet * Enable visits management for admitted patients * Fixes by comments review * Avoid automatic saving and have changes all buffered before save * Fix visit automatic save in worksheet * Fix layout * Fix deletion on second day list * reload data from DB upon new visits * Fix MessageDialog calls * Organize imports * Fix bundle * Small workaround to avoid cursor jumps among new items in the same day TODO: - better arrays management (to highlight also unsaved) - improve events handling (to avoid selection flickering) * Add validation for visits buffered to save * Avoid Worksheet operativity when there are visit changes pending * Fixes by comments review * Sync Swing quantity controllers * Avoid Worksheet operativity when there are therapies changes pending * Avoid therapies in the past and improved bundles
mwithi
reviewed
Sep 13, 2021
mwithi
reviewed
Sep 13, 2021
mwithi
reviewed
Sep 13, 2021
mwithi
reviewed
Sep 13, 2021
- run always telemetry daemon - (except if settings.properties disables it) - added dialog with the content of the tlemetry message that will be sent to https://www.informaticisenzafrontiere.org/ - corrected what Alessandro asked to change
mwithi
added a commit
that referenced
this pull request
Sep 16, 2022
* Telemetry updates added Telemetry popup + configuration renamed SmsSender class to SmsDaemon * resolved conflict * OP-153 Fix lots quantities on multiple discharges * sync + little changes * - added headers * added freegeoip remote service configuration + changed package name fro data collector module * corrections based on Alessandro's suggestions * corrections based on Alessandro's suggestions * restored old variable name (reason: in the future we will do a refactoring) * new db single connection config + ipinfo config * fixed some bugs - now telemetry is based on the following rules: if active = null => show telemetry popup, if active = true => start telemetry daemon, if active = false => do nothing (we should add a menu item in order to allow user to access to the popup?) - if TELEMETRYENABLED is yes then start telemetry daemon always (with SINGLEUSER equals to yes or no) * implementation telemetry module completed + added also simulated message sending (when DEBUG=yes) * added property to enable/disable telemetry module * Added Telemetry menu item in the Settings menu + managed the case when telemetry module is disabled from settings.properties (could be used for other OH modules): we will not show the menu item in the Settings menu * OP-149 Set default duration (30min) and date check on visits. (#877) * Set default duration (30min) and date check on visits. Also clean and improve code * Fix for multiple visit save * Fix as per comments review * Fix therapy changes and also refactor constants * Fix spacing * Fix edit therapy (not insert) Fix also duration calculation * Fix window position after re-pack * Add remove visit button in worksheet * Enable visits management for admitted patients * Fixes by comments review * Avoid automatic saving and have changes all buffered before save * Fix visit automatic save in worksheet * Fix layout * Fix deletion on second day list * reload data from DB upon new visits * Fix MessageDialog calls * Organize imports * Fix bundle * Small workaround to avoid cursor jumps among new items in the same day TODO: - better arrays management (to highlight also unsaved) - improve events handling (to avoid selection flickering) * Add validation for visits buffered to save * Avoid Worksheet operativity when there are visit changes pending * Fixes by comments review * Sync Swing quantity controllers * Avoid Worksheet operativity when there are therapies changes pending * Avoid therapies in the past and improved bundles * Chore: remove duplicate semi-colon (#878) * Chore: remove duplicate code in both branches of if (#879) * Chore: remove what looks like an octal value for int array (#880) * run always telemetry daemon + confirmation dialog with summary - run always telemetry daemon - (except if settings.properties disables it) - added dialog with the content of the tlemetry message that will be sent to https://www.informaticisenzafrontiere.org/ - corrected what Alessandro asked to change Co-authored-by: Alessandro Domanico <[email protected]> Co-authored-by: David B Malkovsky <[email protected]>
ArnaudFonzam
pushed a commit
to ArnaudFonzam/openhospital-gui
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See OP-312.
added Telemetry popup + configuration
renamed SmsSender class to SmsDaemon
This PR is paired with informatici/openhospital-core#479