OP-1376 OP-1377 | Fix some Bug #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbmalkovsky
reviewed
Jan 9, 2025
dbmalkovsky
reviewed
Jan 9, 2025
Co-authored-by: David B Malkovsky <[email protected]>
mwithi
reviewed
Jan 9, 2025
bundle/language_en.properties
Outdated
| @@ -670,6 +670,8 @@ angal.hospital.visitduration.txt | |||
| angal.hospital.visitendhour.txt = Visit end hour | |||
| angal.hospital.visitstarthour.txt = Visit start hour | |||
| angal.inventory.addproduct.label = Add products | |||
| angal.inventory.allinventoryrowshouldhaverealqtygreatterthanzero.msg = All inventory(ies) row(s) should have real quantity greater than zero. | |||
There was a problem hiding this comment.
This is not true.... I try to explain again but please check that the whole code is consistent:
If the lot is NOT NEW, the real quantity CAN be zero, because we are doing an inventory and we are detecting that one existing product/lot is missing.
If the lot is NEW, the real quantity must be GREATER than zero, because it is not possibile to detect a new product/lot if it is missing.
In this extend, the message is not correct. But please, check the logic that uses this message.
There was a problem hiding this comment.
I have update the message
There was a problem hiding this comment.
did you verify the logic if it really checks that only for new lots?
There was a problem hiding this comment.
added 15 commits
January 10, 2025 08:12
mwithi
merged commit 699e696
into
informatici:OP-1199-Main-Store-Inventory
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See OP-1376 and OP-1377.
edit modewhen the user has clean table and close the window directly.