Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: use compiled pattern instead of regular expression that needs to be regenerated each time #1916

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Chore: use compiled pattern instead of regular expression that needs to be regenerated each time #1916

merged 2 commits into from
Dec 26, 2023

Conversation

dbmalkovsky
Copy link
Collaborator

No description provided.

@dbmalkovsky dbmalkovsky requested a review from mwithi December 26, 2023 19:25
mwithi
mwithi approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@mwithi mwithi merged commit d6637e7 into informatici:develop Dec 26, 2023
1 check passed
@dbmalkovsky dbmalkovsky deleted the dbmRegExpressionCompiledPattern branch December 26, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwithi mwithi mwithi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbmalkovsky @mwithi