OH2-255 Revise and align permissions for CORE, API and UI #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove duplicates - added missing - refactored some controllers and endpoints (resources in plurals) - made permission spelled like endpoint - sorted in alphabetical order, then CRUD - removed PATCH methods
and so remove discharges.* permissions, admission.* ones will be used.
mwithi
requested review from
dbmalkovsky,
axelpezzo and
npasquetto
and removed request for
axelpezzo
mwithi
changed the title
dbmalkovsky
approved these changes
Dec 13, 2023
Merged
OH2-255-revise-permissions-among-core-api-and-ui
mwithi
commented
Dec 20, 2023
|
@npasquetto after #415 we have to update also informatici/openhospital-ui#538 ? |
Yes, due to the naming refactoring, the SPA API client must be regenerated |
Ok, let me do that, thanks! |
mwithi
added a commit
to informatici/openhospital-ui
that referenced
this pull request
Dec 21, 2023
@npasquetto done! please test with informatici/openhospital-ui#538 |
npasquetto
approved these changes
Dec 22, 2023
mwithi
added a commit
to informatici/openhospital-ui
that referenced
this pull request
Jan 9, 2024
* Permissions redefinition * Move /discharges to /admissions/discharges endpoint and so remove discharges.* permissions, admission.* ones will be used. * Change visits.access -> opds.access * Fix laboratories permissions Exam is the object ExamRow is the detail of the Exam object Laboratory is the activity (called also "exam") concerning one Exam object LaboratoryRow is the detail of a Laboratory activity Examination is another activity, done by the doctor, nothing to do with the Exam object or Laboratory activity * Aling with informatici/openhospital-api#411 * Replace with runtime.ts from develop * Fix pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See OH2-255.
/dischargesto/admissions/dischargesendpoint and remove related permissions (admissions.*ones will be used)