Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix for doc tests breaking nightly build #838

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

thanethomson
Copy link
Contributor

Just a minor thing that seems to have come up that's breaking nightly. See here.

Not sure if there's a way around this in doc tests?

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@thanethomson thanethomson added bug Something isn't working ci Related to continuous integration labels Mar 25, 2021
@thanethomson thanethomson changed the title Minor fix doc for tests breaking nightly build Minor fix for doc tests breaking nightly build Mar 25, 2021
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔆 🌑 ⏸ 🔧

Copy link
Contributor

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure why this didn't fail the principle tests. Sorry about that!

@thanethomson thanethomson merged commit bf80e78 into master Mar 25, 2021
@thanethomson thanethomson deleted the thane/fix-nightly branch March 25, 2021 15:58
@thanethomson
Copy link
Contributor Author

Could possibly be due to compiler changes in Rust 1.51 🤷‍♂️ I'm seeing a bunch of new clippy errors and warnings now (e.g. #839).

thanethomson added a commit that referenced this pull request Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Related to continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants