Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testgen: Compute last_block_id hash when generating a light chain #746

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

romac
Copy link
Member

@romac romac commented Dec 15, 2020

Close #744
Close #745

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

@romac romac changed the title [testgen] Compute last_block_id hash when generating a light chain testgen: Compute last_block_id hash when generating a light chain Dec 15, 2020
@romac romac added the tests label Dec 15, 2020
@romac romac force-pushed the romac/testgen-last-block-id branch from 42a1259 to 57b0a6d Compare December 15, 2020 18:45
@codecov-io
Copy link

Codecov Report

Merging #746 (57b0a6d) into master (4225d7f) will increase coverage by 0.0%.
The diff coverage is 77.1%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #746   +/-   ##
======================================
  Coverage    43.2%   43.3%           
======================================
  Files         203     203           
  Lines       13118   13169   +51     
  Branches     3456    3483   +27     
======================================
+ Hits         5673    5705   +32     
- Misses       7087    7104   +17     
- Partials      358     360    +2     
Impacted Files Coverage Δ
testgen/src/light_block.rs 79.8% <0.0%> (-1.9%) ⬇️
testgen/src/header.rs 75.5% <54.5%> (-2.1%) ⬇️
testgen/src/light_chain.rs 93.9% <88.3%> (+1.3%) ⬆️
tendermint/src/hash.rs 57.2% <0.0%> (-6.2%) ⬇️
testgen/src/helpers.rs 78.3% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4225d7f...57b0a6d. Read the comment docs.

Shivani912
Shivani912 previously approved these changes Dec 16, 2020
Copy link
Contributor

@Shivani912 Shivani912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this @romac ! ❤️

Copy link
Contributor

@Shivani912 Shivani912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍

@Shivani912 Shivani912 merged commit 462eafc into master Dec 16, 2020
@Shivani912 Shivani912 deleted the romac/testgen-last-block-id branch December 16, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants