Specify proposer when constructing validator set in light client #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
ancazamfir
previously approved these changes
Dec 1, 2020
melekes
reviewed
Dec 4, 2020
| pub fn new( | ||
| validators: Vec<Info>, | ||
| proposer: Option<Info>, | ||
| total_voting_power: vote::Power, | ||
| total_voting_power: Option<vote::Power>, |
There was a problem hiding this comment.
why would someone need to pass total_voting_power if it can be computed?
There was a problem hiding this comment.
Yeah I wonder about this as well. Maybe @ebuchman knows why it was done like this?
There was a problem hiding this comment.
they do not I've been campaigning against total voting power and proposer fields in this type for a few weeks now! I suspect it was done without really thinking about it ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #705
This PR also refactors the constructors of
validator::Setand precomputes the total voting power in the set.