Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl lite::ValidatorSetLookup #68

Merged
merged 1 commit into from
Nov 13, 2019
Merged

impl lite::ValidatorSetLookup #68

merged 1 commit into from
Nov 13, 2019

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Nov 13, 2019

No description provided.

liamsi
liamsi approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

tendermint/src/validator.rs
.find(|val| val.address == val_id)
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cool to add a little test for this. Happy to do so after merging.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in: 23042bb

@liamsi liamsi merged commit c8d17a9 into informalsystems:lite_impl_simple_merkle_merged Nov 13, 2019
@liamsi liamsi mentioned this pull request Nov 13, 2019
Merged
@liamsi liamsi mentioned this pull request Nov 27, 2019
Closed
@liamsi liamsi mentioned this pull request Dec 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamsi liamsi liamsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihuang @liamsi