Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use concrete basic types for time, hash, bytes, validator id #51

Merged
merged 5 commits into from
Nov 1, 2019
Merged

Use concrete basic types for time, hash, bytes, validator id #51

merged 5 commits into from
Nov 1, 2019

Commits on Oct 29, 2019

  1. Use concrete basic types for time, hash, bytes, validator id

    @liamsi
    liamsi committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    35b511a View commit details
    Browse the repository at this point in the history

  2. cargo fmt

    @liamsi
    liamsi committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    f07f97d View commit details
    Browse the repository at this point in the history

  3. make the lite client a module instead of a separate crate: 

    This is just the simplest way to move forward implementing the traits of
the lite package. There are alternatives:
We do not want a create a circular dependency between lite and
tendermint (which does not even compile). To avoid this we could:
1) make lite a module of tendermint, or, 2) replicate a lot of the types
of the tendermint crate in the lite package (e.g. Time, Ids etc), or 3)
have a dependency from tendermint to the lite package only (but then the
trait impls do need to live in the lite crate instead with the types in
the tendermint crate directly).

copied changes over from
d3ce237
    @liamsi
    liamsi committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    b5d0a37 View commit details
    Browse the repository at this point in the history

  4. clippy: ineffective operation total_power * 1

    @liamsi
    liamsi committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    8dcc1e4 View commit details
    Browse the repository at this point in the history

  5. uncomment expired logic

    @liamsi
    liamsi committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    b23d745 View commit details
    Browse the repository at this point in the history