Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.23.x: Add support for HTTP Basic authentication to HTTP and WebSocket RPC clients #1170

Merged
merged 6 commits into from
Aug 2, 2022
Merged

v0.23.x: Add support for HTTP Basic authentication to HTTP and WebSocket RPC clients #1170

merged 6 commits into from
Aug 2, 2022

Conversation

romac
Copy link
Member

@romac romac commented Jul 28, 2022 •
edited
Loading

Closes: #1169

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@romac romac changed the base branch from master to v0.23.x July 28, 2022 16:29
@romac romac changed the title Add support for HTTP Basic authentication in HTTP and WebSocket RPC clients Add support for HTTP Basic authentication to HTTP and WebSocket RPC clients Jul 29, 2022
@romac romac changed the title Add support for HTTP Basic authentication to HTTP and WebSocket RPC clients v0.23.x: Add support for HTTP Basic authentication to HTTP and WebSocket RPC clients Jul 29, 2022
@romac romac requested a review from thanethomson July 29, 2022 09:38
@romac romac marked this pull request as ready for review July 29, 2022 09:38
thanethomson
thanethomson reviewed Jul 29, 2022
View reviewed changes
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On first pass this mostly looks good to me! Just a couple of minor things.

.changelog/unreleased/features/1169-basic-auth.md Outdated Show resolved Hide resolved
rpc/src/client/transport/auth.rs Outdated Show resolved Hide resolved
rpc/src/rpc_url.rs Outdated Show resolved Hide resolved
rpc/src/rpc_url.rs Show resolved Hide resolved
@romac
Copy link
Member Author

romac commented Jul 30, 2022

Should be good to go :)

thanethomson
thanethomson approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks @romac!

@thanethomson thanethomson merged commit 590a038 into v0.23.x Aug 2, 2022
@thanethomson thanethomson deleted the romac/basic-auth branch August 2, 2022 11:31
@thanethomson thanethomson mentioned this pull request Aug 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanethomson thanethomson thanethomson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for HTTP Basic authentication in HTTP and WebSocket RPC clients
2 participants
@romac @thanethomson