Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Hash on tendermint::Time #1054

Merged
merged 3 commits into from
Dec 13, 2021
Merged

Conversation

mzabaluev
Copy link
Contributor

@mzabaluev mzabaluev commented Dec 13, 2021

Now that we're backed by a data structure with unambiguously unique values, we can make time moments hashable.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

Now that we're backed by a data structure with unambiguously unique
values, we can make time moments hashable.
@mzabaluev mzabaluev added domain-types Anything relating to the creation, modification or removal of domain types enhancement New feature or request labels Dec 13, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1054 (597296d) into master (01ff277) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1054     +/-   ##
========================================
- Coverage    62.5%   62.4%   -0.2%     
========================================
  Files         236     236             
  Lines       21321   21342     +21     
========================================
- Hits        13331   13319     -12     
- Misses       7990    8023     +33     
Impacted Files Coverage Δ
tendermint/src/time.rs 98.5% <100.0%> (ø)
tendermint/src/evidence.rs 21.6% <0.0%> (-3.8%) ⬇️
config/src/config.rs 55.0% <0.0%> (-1.5%) ⬇️
testgen/src/validator.rs 86.7% <0.0%> (-0.8%) ⬇️
abci/src/server.rs 9.2% <0.0%> (-0.4%) ⬇️
tendermint/src/node.rs 63.7% <0.0%> (+0.1%) ⬆️
testgen/src/header.rs 80.2% <0.0%> (+0.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ff277...597296d. Read the comment docs.

greg-szabo
greg-szabo previously approved these changes Dec 13, 2021
Copy link
Member

@greg-szabo greg-szabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@thanethomson
Copy link
Contributor

Nice! Ready to merge this, or is there more you want to do here?

@mzabaluev
Copy link
Contributor Author

Oh, let me dress it up with a changelog entry :)

@mzabaluev mzabaluev marked this pull request as ready for review December 13, 2021 18:27
@thanethomson thanethomson merged commit 6e33529 into master Dec 13, 2021
@thanethomson thanethomson deleted the mikhail/derive-hash-on-time branch December 13, 2021 20:46
thanethomson pushed a commit that referenced this pull request Dec 13, 2021
thanethomson added a commit that referenced this pull request Dec 13, 2021
Signed-off-by: Thane Thomson <[email protected]>

Co-authored-by: Mikhail Zabaluev <[email protected]>
romac pushed a commit that referenced this pull request Mar 6, 2023
This reintroduces #1054 after it was removed in #1203.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain-types Anything relating to the creation, modification or removal of domain types enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants