docs: ADR-010 enabling standalone ICS-02 integration #1116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanchen1991
reviewed
Mar 6, 2024
docs/architecture/adr-010-enable-standalone-ics02-integration.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-010-enable-standalone-ics02-integration.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-010-enable-standalone-ics02-integration.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-010-enable-standalone-ics02-integration.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-010-enable-standalone-ics02-integration.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-010-enable-standalone-ics02-integration.md
Outdated
Show resolved
Hide resolved
docs/architecture/adr-010-enable-standalone-ics02-integration.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Sean Chen <[email protected]> Signed-off-by: Farhad Shabani <[email protected]>
Co-authored-by: Sean Chen <[email protected]> Signed-off-by: Farhad Shabani <[email protected]>
rnbguy
approved these changes
Mar 8, 2024
Member
rnbguy
left a comment
rnbguy
left a comment
There was a problem hiding this comment.
LGTM 👍
One comment about listing future solutions for the negative consequences.
docs/architecture/adr-010-enable-standalone-ics02-integration.md
Outdated
Show resolved
Hide resolved
Farhad-Shabani
deleted the
farhad/adr010-enable-standolone-ics02-integration
branch
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
* docs: ADR-010 enabling standalone ICS-02 integration * imp: explaining why decode_client_state will be removed * imp: use diff-formatted code snippets * chore: put a comment for decode_client_state * chore: apply suggestions from code review Co-authored-by: Sean Chen <[email protected]> Signed-off-by: Farhad Shabani <[email protected]> * chore: apply suggestions from code review Co-authored-by: Sean Chen <[email protected]> Signed-off-by: Farhad Shabani <[email protected]> * imp: update with details for host_consensus_state & validate_self_client * nit: lint markdown * nit: rename to HostClient/ConsensusState * imp: update ADR with changes in implementation PR * chore: back to the original implementation idea * fix: adjust ClientStateDecoder * nit * nit: add comment for minimizing associated types --------- Signed-off-by: Farhad Shabani <[email protected]> Co-authored-by: Sean Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Rendered
Part of: #1114
Implementation PR: #1115
PR author checklist:
docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.