Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add height parameter to query commitments #4194

Merged
merged 3 commits into from
Sep 28, 2024
Merged

Add height parameter to query commitments #4194

merged 3 commits into from
Sep 28, 2024

Conversation

ancazamfir
Copy link
Collaborator

Partially closes: #4193

Description

Added query height option to the query commitments CLi

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ancazamfir ancazamfir added this pull request to the merge queue Sep 28, 2024
Merged via the queue into master with commit 84743a2 Sep 28, 2024
30 checks passed
@ancazamfir ancazamfir deleted the anca/commitments_query_height branch September 28, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add query height option to the query commitments and other queries
2 participants
@ancazamfir @romac