Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specify more flexible gas price on feemarket chains #2566

Closed
5 tasks
yihuang opened this issue Aug 16, 2022 · 0 comments · Fixed by #2573
Closed
5 tasks

Support specify more flexible gas price on feemarket chains #2566

yihuang opened this issue Aug 16, 2022 · 0 comments · Fixed by #2573
Milestone

Comments

@yihuang
Copy link
Contributor

yihuang commented Aug 16, 2022

Summary

Since the introduction of priority mempool and feemarkets, we need more flexibility to customize the tx building process, mainly the gas price-related stuff.
Also as a workaround of the tx reorder issue, we need different strategies for different chains to control the tx priority:

  • With the SDK default mechanism plus this fix, the current static gas price works fine.
  • With the feemarket introduced in ethermint, we need to add an extension option(ExtensionOptionDynamicFeeTx) to specify a max_priority_price.

Problem Definition

Proposal

  • Change the type of config::GasPrice to sth like:

    enum GasPrice {
      Static(string, f64),
      EthermintDynamicFee(string, f64, u64),
    }
  • Update tx building logic accordingly.

  • Add a config item to specify extension options for the tx.

    enum ExtensionOption {
      EthermintDynamicFee(string),
    }

Acceptance Criteria


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@yihuang yihuang changed the title Support more flexible gas price strategies Support specify more flexible gas price on feemarket chains Aug 16, 2022
yihuang added a commit to yihuang/ibc-rs that referenced this issue Aug 17, 2022
yihuang added a commit to yihuang/ibc-rs that referenced this issue Aug 17, 2022
@romac romac added this to the v1.1 milestone Aug 18, 2022
@romac romac closed this as completed in 13669ca Aug 24, 2022
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this issue Sep 13, 2022
Closes: informalsystems#2566

* Support custom extension options when building tx

* Cargo.lock is outdated

* optimize serde encoding

* fix clippy and test

* Add changelog entry

* Fix clippy warnings

* Fix compilation

* Fix clippy warnings

Co-authored-by: Sean Chen <[email protected]>
Co-authored-by: Romain Ruetschi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants