Skip to content

chore: refactor staking integration, sims and e2e tests#8

Merged
sainoe merged 33 commits intofeat/lsm/v0.47.xfrom
sainoe/lsm-staking-test
Dec 8, 2023
Merged

chore: refactor staking integration, sims and e2e tests#8
sainoe merged 33 commits intofeat/lsm/v0.47.xfrom
sainoe/lsm-staking-test

Conversation

@sainoe
Copy link
Copy Markdown

@sainoe sainoe commented Dec 6, 2023

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Copy Markdown

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the number of validators.

We should not reflect our local environments in tests that largely run in the CI.

Copy link
Copy Markdown

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the changes

@MSalopek MSalopek changed the title chore: refactor staking integration tests chore: refactor staking integration, sims and e2e tests Dec 7, 2023
@sainoe sainoe merged commit b50f5a7 into feat/lsm/v0.47.x Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants