Drop codemirror-rails and coffee => Rails 6 + 7 support #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from https://github.com/fixlr/codemirror-rails/tree/master/vendor/assets commit cb5e9eee1bac8b8b6933d330591a5f83100094d8. This is identical to version "5.16.0" of "codemirror-rails".
apepper
changed the title
dcsaszar
requested changes
May 13, 2022
| @@ -2,7 +2,7 @@ Gem::Specification.new do |s| | |||
| s.author = 'Scrivito' | |||
| s.description = 'Make CodeMirror available as a Scrivito editor' | |||
| s.email = '[email protected]' | |||
| s.files = Dir['READ*', 'LIC*', 'app/**/*', 'lib/**/*'] | |||
| s.files = Dir['READ*', 'LIC*', 'app/**/*', 'lib/**/*', 'vendor/**/*'] | |||
There was a problem hiding this comment.
- The CodeMirror code looks like the addons rely on the main script to be loaded first. If I read this correctly, we should make the order explicit.
There was a problem hiding this comment.
This is how codemirror-rails defines its "files":
So I think we're ok with the current approach.
There was a problem hiding this comment.
I see. Ruby even turned to sorted at some point: https://bugs.ruby-lang.org/issues/8709
Since // CodeMirror, copyright (c) by Marijn Haverbeke and others
// Distributed under an MIT license: http://codemirror.net/LICENSEI think mixing them is good enough. But since |
dcsaszar
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/fixlr/codemirror-rails is officially not supporting Rails 6 or Rails 7. But both rails versions still support the asset pipeline if needed.
This PR converts "coffee" to plain js to remove the coffee dependency.
It also inlines the "vendor/" part of
codemirror-railsso that it can be directly used. So versionCodeMirror 5.16.0is now included in the package itself.