Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent dependency hell by splitting go mods #283

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kanaksinghal
Copy link

No description provided.

@chinmayb
Copy link
Contributor

require (
github.com/golang/protobuf v1.5.4
github.com/google/go-cmp v0.6.0
github.com/lib/pq v1.10.9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this might not actually be needed:

_ "github.com/lib/pq"

I don't see anything in this file that would depend on pq being registered.

Comment on lines +109 to +111
cd types && go mod tidy
cd example && go mod tidy
go mod tidy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can future proof this with

Suggested change
cd types && go mod tidy
cd example && go mod tidy
go mod tidy
find . -name go.mod -execdir go mod tidy \;

@kd7lxl kd7lxl requested a review from Calebjh January 23, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants