Upgrade gORM to V2 #237
Upgrade gORM to V2 #237
Conversation
|
Please do not merge this PR until discussion is finished and explicit note mentions it. This PR might depend on new changes in toolkit |
| @@ -23,12 +23,12 @@ message User { | |||
| uint32 age = 5 [(gorm.field).drop = true]; // synthetic field | |||
| uint32 num = 6; | |||
| CreditCard credit_card = 7; // has one | |||
| repeated Email emails = 8; // has many | |||
| repeated Task tasks = 9 [(gorm.field).has_many = {position_field: "priority" foreignkey_tag: {not_null: true}}]; | |||
| repeated Email emails = 8 [(gorm.field).has_many = {disable_association_autocreate: true disable_association_autoupdate: true preload: true}]; // has many | |||
There was a problem hiding this comment.
Is the default preload setting changing to false?
There was a problem hiding this comment.
I believe it always was like this and had to be enabled like following: gORMv1
README.md
Outdated
| @@ -135,7 +135,7 @@ Within the proto files, the following types are supported: | |||
| level. | |||
| - custom wrapper type `gorm.types.JSONValue`, which wraps a string in protobuf | |||
| containing arbitrary JSON and converts to `postgres.Jsonb` GORM type | |||
| (https://github.com/jinzhu/gorm/blob/master/dialects/postgres/postgres.go#L59) | |||
| (https://gorm.io/gorm/blob/master/dialects/postgres/postgres.go#L59) | |||
There was a problem hiding this comment.
The /dialects directory doesn't exist in GormV2, I don't think
| @@ -876,8 +879,8 @@ func (b *ORMBuilder) parseBasicFields(msg *protogen.Message, g *protogen.Generat | |||
| fieldType = "*" + generateImport("Time", stdTimeImport, g) | |||
| } else if rawType == protoTypeJSON { | |||
| if b.dbEngine == ENGINE_POSTGRES { | |||
| typePackage = gormpqImport | |||
| fieldType = "*" + generateImport("Jsonb", gormpqImport, g) | |||
| typePackage = gtypesImport | |||
There was a problem hiding this comment.
Can we leverage the new JSON datatype from upstream, or is the custom one better (maybe simpler)? https://github.com/go-gorm/datatypes
There was a problem hiding this comment.
I'm generally concerned over the fact, that we have a pointer to the struct. Thus I can assume, that some application code might rely on checking for nil field value, while new JSON datatype will hold "null" in case scanned from DB and we can't easily distinguish empty slice value from nil slice.
|
Is there an intent to land this change any time soon? It would be great to get gorm2 support. |
|
Any update? |
Upgrade gORM to V2This PR introduces new version of
gORMin accordance to release notes:association_autocreate,association_autoupdate,preloadtags from generated code, however replaces them with required code generation:association_autocreate&association_autoupdateare replaced withOmit(<field_name>callspreloadis replaced withPreload(<field_name>)callsassociation_save_referenceis removed as it is missing equivalent ingORMv2JsonbfieldsNOTE: Currently this PR is dependent on toolkit:gorm_v2 branch, which is not master, merges should be performed with @Calebjh agreement/review