Add new filtering operators #123
Conversation
…lock, update tests
gorm/filtering_test.go
Outdated
| @@ -2,11 +2,11 @@ package gorm | |||
|
|
|||
| import ( | |||
| "context" | |||
| "github.com/infobloxopen/atlas-app-toolkit/query" | |||
There was a problem hiding this comment.
why the order of imports was changed. Typically we try to break imports in 3 different sections with a newline between each one to separate standard imports, third party imports, imports from infobloxopen
There was a problem hiding this comment.
Sorry, i think it because i did use standart go format tool and it perform sorting imports as one of format operation, i will try be more careful about this
README.md
Outdated
| @@ -1004,6 +1004,8 @@ Literal values include numbers (integer and floating-point), and quoted (both si | |||
| | or | Logical OR | price <= 3.5 or price > 200 | | |||
| | not | Logical NOT | not price <= 3.5 | | |||
| | () | Grouping | (priority == 1 or city == ‘Santa Clara’) and price > 100 | | |||
| | := | Insensitive equal | city := 'SaNtA ClArA' | | |||
There was a problem hiding this comment.
Why we don't add a literal representation of the operator?(ie)
Seems like any other operator has it.
There was a problem hiding this comment.
Evgeniy-L sent me documentation and i did all folow the documentation, in this document string representation not exist for ':=' operator and i did't add it, if you think we need alias 'ie' for ':=' operator, i can add it
There was a problem hiding this comment.
@dkukharau, @burov, ie doesn't look intuitively clear. Have you seen something like this anywhere it is is just something we just invented?
There was a problem hiding this comment.
I don't like the idea of adding uncommon things
There was a problem hiding this comment.
Ok, let's name it ieq, there is such operator in PowerShell.
There was a problem hiding this comment.
@Evgeniy-L what you think about this operator, what we need to do? Change alias to 'ieq' or remove alias ?
There was a problem hiding this comment.
ok, lets have it added as ieq
| []interface{}{"sOmeId", "egegeg", "Hello"}, | ||
| nil, | ||
| nil, | ||
| }, |
There was a problem hiding this comment.
Need a test case for ArrayNumberCondition as well - not a complex expression, just a simple one.
query/filtering_lexer.go
Outdated
| values := make([]string, 0) | ||
| for lexer.curChar != term || lexer.eof { | ||
| switch lexer.curChar { | ||
| case ' ', ',': |
There was a problem hiding this comment.
unicode.IsSpace should be used here to check a whitespace.
| @@ -37,6 +36,9 @@ func TestFilteringLexer(t *testing.T) { | |||
| LeToken{}, | |||
| LeToken{}, | |||
| NullToken{}, | |||
| InsensitiveEqToken{}, | |||
There was a problem hiding this comment.
Also good to have negative tests for empty array([]), array with both strings and numbers(["abc", 1, 2]), unclosed array([1,2,)
I add new filtering operators, such as in(val in array for number and string arrays) and := (Insensitive equal operator)