feat: Color Map pass the colorMapping object to giraffe
#3473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChitlangeSahas
changed the title
colorMapping object to giraffe
|
ChitlangeSahas
commented
Dec 20, 2021
package.json
Outdated
| "cy:dev": "source ../monitor-ci/.env && CYPRESS_dexUrl=CLOUD CYPRESS_baseUrl=https://$INGRESS_HOST:$PORT_HTTPS cypress open --config testFiles='{cloud,shared}/**/*.*'", | ||
| "cy:dev-oss": "source ../monitor-ci/.env && CYPRESS_dexUrl=OSS CYPRESS_baseUrl=https://$INGRESS_HOST:$PORT_HTTPS cypress open --config testFiles='{oss,shared}/**/*.*'", | ||
| "generate": "export SHA=2da36d4beb7fc22dd8d037c3398c91c7ca2c346d && export REMOTE=https://raw.githubusercontent.com/influxdata/openapi/${SHA}/ && yarn generate-meta", | ||
| "generate": "export SHA=018d2381f78e52acbe1deaaff4c9512adf5e3703 && export REMOTE=https://raw.githubusercontent.com/influxdata/openapi/${SHA}/ && yarn generate-meta", |
Contributor
Author
There was a problem hiding this comment.
this SHA lives in a branch, maybe we should wait for this PR influxdata/openapi#248
| * 'result', | ||
| * ], | ||
| * | ||
| * the seriesID would be : "co-airSensors-TLM0102-mean-" |
| interpolation, | ||
| position: properties.position, | ||
| colors: colorHexes, | ||
| colorMapping, |
Contributor
There was a problem hiding this comment.
an alternative to passing in colorMapping: null when the flag is off is doing something like:
remove this line in the definition of config, and then below where config is defined, doing this:
if (isFlagEnabled('graphColorMapping')) {
config.colorMapping = colorMapping
}to make sure this is truly 'dark' in the sense that it makes no changes to production code if the flag is off.
hoorayimhelping
approved these changes
Dec 20, 2021
| @@ -0,0 +1,402 @@ | |||
| // tests will go here | |||
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3098
Bigger Picture:
The
translateis basically looking at theviewProperties.colorMappingobject from theidpeand then looking up thecolorusing the index in theproperties.colorsarray. We then embed thecolorproperty into themappings.[series_index]object in giraffe.Visualization of how the colorMapping object is translated into color for the giraffe. This translation happens in the UI. (
getColorMappingObjectsfunction)