-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Updates #779
Build Updates #779
Conversation
looks good, thanks @rossmcdonald, Just one thing: I'd rather that the tests here and in the Makefile not diverge. Telegraf requires some docker containers for the tests to run so I'm pretty sure running the tests from build.py will fail. Could we remove the run_tests function from here, or have it just execute |
@sparrc Yes, absolutely. I left the tests function in this version since they are a part of the InfluxDB and Kapacitor build processes, but I can take them out if they're not useful to you. I'm also going to be re-adding the zip package functionality that was removed. I didn't realize that had been modified to be a manual process (instead of using fpm), so I should have this ready by EOD today. I'll ping you once it's ready for merging. |
oh, sorry about that, I removed using fpm because it was creating zips with temp directories inside them that I couldn't figure out how to remove |
No worries at all. I could never figure out how to fix the zip's from including the temp directories, so I just removed them from the InfluxDB and Kapacitor package targets to simplify things. I'll re-add that portion, though. |
Added in another fix to the post-install script, removed the test functionality, and re-added the |
…ocess to use the base 'tar' and 'zip' commands, instead of 'fpm'.
…s having the incorrect permissions on the log directory.
9f8175d
to
8ef3c58
Compare
8ef3c58
to
b4b1866
Compare
Some major changes to the
build.py
build script, including:pkgarch
andgoarm
build arguments<version>~n<epoch>
over<version>.n<epoch>