Zookeeper plugin #262
Closed
Zookeeper plugin #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a zookeeper plugin that fetches from the ‘mntr’ command will output measurements that are int and string based
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestMemcachedGeneratesMetrics(t *testing.T) { |
There was a problem hiding this comment.
name of this function shouldn't be memcached?
There was a problem hiding this comment.
Whoops will fix that was basing the test file based off memcached test plugin.
|
Your method of unit testing requires that you add a zookeeper docker image to the |
|
please write a README detailing all measurements that will be output, you can use the CPU_README.md file in the |
| err := z.Gather(&acc) | ||
| require.NoError(t, err) | ||
|
|
||
| intMetrics := []string{"zookeeper_avg_latency", "zookeeper_packets_sent", "zookeeper_znode_count", "zookeeper_open_file_descriptor_count", "zookeeper_max_file_descriptor_count"} |
|
thank you @jrxFive! Just address the comments I made and I can merge 👍 |
since spotify/kafka docker image already exposes zookeeper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a zookeeper plugin that fetches from the ‘mntr’ command will
output measurements that are int and string based