Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for linux sysctl fs metrics #2609

Merged
merged 1 commit into from
Mar 31, 2017
Merged

add support for linux sysctl fs metrics #2609

merged 1 commit into from
Mar 31, 2017

Conversation

phemmer
Copy link
Contributor

@phemmer phemmer commented Mar 31, 2017

Required for all PRs:

  • CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
  • Sign CLA (if not already signed)
  • README.md updated (if adding a new plugin)

phemmer
phemmer commented Mar 31, 2017
View reviewed changes
README.md
@@ -174,6 +174,7 @@ configuration options.
* processes
* kernel (/proc/stat)
* kernel (/proc/vmstat)
* linux_sysctl_fs (/proc/sys/fs)
Copy link
Contributor Author

@phemmer phemmer Mar 31, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I was adding this line, I noticed the naming isn't in line with the other linux-only metrics. The other 2 linux-only measurements are named "kernel_*". We could call this "kernel_sysctl_fs". I don't much like the name, as "kernel" does not indicate that it's linux-specific, but it would be consistent. Perhaps this is just something we fix in 2.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't care for kernel as a name, but we should think about how to make the transition smooth to 2.0, so everything doesn't just get renamed when you switch versions. Maybe we should add the new names as aliases, so people can switch now and then for the real 2.0 all we do is drop support. Obviously thats a lot of work for the size of this change... something to think about though.

@danielnelson danielnelson merged commit 51c99d5 into influxdata:master Mar 31, 2017
@danielnelson danielnelson mentioned this pull request Mar 31, 2017
Closed
@phemmer phemmer deleted the system-file-descriptors branch March 31, 2017 21:55
calerogers pushed a commit to calerogers/telegraf that referenced this pull request Apr 5, 2017
@phemmer @calerogers
add support for linux sysctl fs metrics (influxdata#2609)
4c09c62
@phemmer phemmer mentioned this pull request Apr 11, 2017
Closed
vlamug pushed a commit to vlamug/telegraf that referenced this pull request May 30, 2017
@phemmer
add support for linux sysctl fs metrics (influxdata#2609)
612c25a
maxunt pushed a commit that referenced this pull request Jun 26, 2018
@phemmer @danielnelson
add support for linux sysctl fs metrics (#2609)
0def641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielnelson danielnelson danielnelson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phemmer @danielnelson