Add configuration docs to Postgresql input plugin #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add configuration docs to PostgreSQL input plugin README (mostly from the source code) though I've not included the configuration example that seems to use all he connections on the database[1]. [1] #2410
sparrc
reviewed
Mar 8, 2017
plugins/inputs/postgresql/README.md
Outdated
| All connection parameters are optional. Without the dbname parameter, the driver will default to a database with the same name as the user. This dbname is just for instantiating a connection with the server and doesn't restrict the databases we are trying | ||
| to grab metrics for. | ||
|
|
||
| `address = "host=localhost user=postgres sslmode=disable"` |
There was a problem hiding this comment.
though I've not included the configuration example that seems to use all he connections on the database[1]
I think you've included it here?
danielnelson
reviewed
Mar 8, 2017
plugins/inputs/postgresql/README.md
Outdated
|
|
||
| `ignored_databases = ["postgres", "template0", "template1"]` | ||
|
|
||
| A list of databases to pull metrics about. If not specified, metrics for all databases are gathered. Do NOT use with the 'ignore_databases' option. |
There was a problem hiding this comment.
Typo in ignored_databases
|
Thanks for pointing out the errors, should be fixed now. |
|
thanks! |
ssorathia
pushed a commit
to ssorathia/telegraf
that referenced
this pull request
Mar 25, 2017
* Add configuration docs to Postgresql input plugin Add configuration docs to PostgreSQL input plugin README (mostly from the source code) though I've not included the configuration example that seems to use all he connections on the database[1]. [1] influxdata#2410 * Fix typo in readme and sampleConfig string.
calerogers
pushed a commit
to calerogers/telegraf
that referenced
this pull request
Apr 5, 2017
* Add configuration docs to Postgresql input plugin Add configuration docs to PostgreSQL input plugin README (mostly from the source code) though I've not included the configuration example that seems to use all he connections on the database[1]. [1] influxdata#2410 * Fix typo in readme and sampleConfig string.
vlamug
pushed a commit
to vlamug/telegraf
that referenced
this pull request
May 30, 2017
* Add configuration docs to Postgresql input plugin Add configuration docs to PostgreSQL input plugin README (mostly from the source code) though I've not included the configuration example that seems to use all he connections on the database[1]. [1] influxdata#2410 * Fix typo in readme and sampleConfig string.
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
* Add configuration docs to Postgresql input plugin Add configuration docs to PostgreSQL input plugin README (mostly from the source code) though I've not included the configuration example that seems to use all he connections on the database[1]. [1] #2410 * Fix typo in readme and sampleConfig string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration docs to PostgreSQL input plugin README (mostly from the source code) though I've not included the configuration example that seems to use all he connections on the database[1].
[1] #2410
Required for all PRs: