Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create a global statsd "previous instance" #2185

Merged
merged 1 commit into from
Dec 20, 2016
Merged

Do not create a global statsd "previous instance" #2185

merged 1 commit into from
Dec 20, 2016

Conversation

sparrc
Copy link
Contributor

@sparrc sparrc commented Dec 20, 2016

this basically reverts #887

at some point we might want to do some special handling of reloading
plugins and keeping their state intact, but that will need to be done at
a higher level, and in a way that is thread-safe for multiple input
plugins of the same type.

Unfortunately this is a rather large feature that will not have a quick
fix available for it.

fixes #1975
fixes #2102

Required for all PRs:

  • CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
  • Sign CLA (if not already signed)
  • README.md updated (if adding a new plugin)

this basically reverts #887

at some point we might want to do some special handling of reloading
plugins and keeping their state intact, but that will need to be done at
a higher level, and in a way that is thread-safe for multiple input
plugins of the same type.

Unfortunately this is a rather large feature that will not have a quick
fix available for it.

fixes #1975
fixes #2102
@sparrc
Copy link
Contributor Author

sparrc commented Dec 20, 2016

cc @kostasb

@sparrc sparrc merged commit 200237a into master Dec 20, 2016
@sparrc sparrc deleted the cs1975 branch January 6, 2017 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fatal error: concurrent map writes Statsd metrics not isolated per plugin
2 participants