Default SNMP parameter changes #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @phemmer can you take a look? what do you think of changing these? |
phemmer
reviewed
Sep 26, 2016
| @@ -105,7 +109,7 @@ type Snmp struct { | |||
| Community string | |||
|
|
|||
| // Parameters for Version 2 & 3 | |||
| MaxRepetitions uint | |||
| MaxRepetitions int | |||
There was a problem hiding this comment.
Just FYI, if this was changed to avoid the conversion on line 613, it'll change again when the gosnmp lib is updated, as it's now a uint8.
|
Looks good to me |
sparrc
force-pushed
the
cs1665
branch
2 times, most recently
from
cacd84c
to
d1f68b6
Compare
max-repetitions = 10 is the default of net-snmp utils according to http://net-snmp.sourceforge.net/docs/man/snmpbulkwalk.html retries = 3 is the default of gosnmp: https://godoc.org/github.com/soniah/gosnmp#pkg-variables Could deal with some parts of the performance issues reported by #1665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
max-repetitions = 10 is the default of net-snmp utils according to
http://net-snmp.sourceforge.net/docs/man/snmpbulkwalk.html
retries = 3 is the default of gosnmp:
https://godoc.org/github.com/soniah/gosnmp#pkg-variables
Could deal with some parts of the performance issues reported
by #1665