Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(service): Set address to prevent orphaned dbus-session processes #16454

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix(service): Set address to prevent orphaned dbus-session processes #16454

merged 1 commit into from
Feb 4, 2025

Conversation

pyksy
Copy link
Contributor

@pyksy pyksy commented Jan 30, 2025 •
edited by srebhan
Loading

Summary

Prevent Telegraf from spawning a stray dbus-session process when started by sysvinit

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #13635

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Jan 30, 2025
@pyksy
Copy link
Contributor Author

pyksy commented Jan 30, 2025

!signed-cla

@srebhan srebhan changed the title fix: Set DBus session address in SysV init script to prevent orphaned… fix(service): Set DBus session address prevent orphaned dbus-session processes Jan 31, 2025
@srebhan srebhan changed the title fix(service): Set DBus session address prevent orphaned dbus-session processes fix(service): Set address to prevent orphaned dbus-session processes Jan 31, 2025
srebhan
srebhan approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @pyksy!

@DStrand1 CI error seems unrelated...

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 31, 2025
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@DStrand1 DStrand1 merged commit ef4cabc into influxdata:master Feb 4, 2025
32 of 33 checks passed
@github-actions github-actions bot added this to the v1.33.2 milestone Feb 4, 2025
srebhan pushed a commit that referenced this pull request Feb 10, 2025
@pyksy @srebhan
fix(service): Set address to prevent orphaned dbus-session processes (#…
1deff75 
…16454)

Co-authored-by: Antti Kultanen <[email protected]>
(cherry picked from commit ef4cabc)
@BrewTestBot BrewTestBot mentioned this pull request Feb 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@DStrand1 DStrand1 DStrand1 approved these changes

Assignees

@DStrand1 DStrand1

Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.33.2
Development

Successfully merging this pull request may close these issues.

Telegraf Generating Orphaned DBus Processes on RHEL Servers #2
3 participants
@pyksy @srebhan @DStrand1