convert Redis to use URI, support Redis AUTH #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jipperinbham This is a great PR but it means that the code ONLY accepts URLs. Can you modify the PR such that if the string is not a URL it is treated the same as it is now? |
|
@evanphx I've updated the PR to fallback to a string based address if the Scheme is not provided. Also, squashed the commits to 1. |
|
@jipperinbham Thanks! |
evanphx
added a commit
that referenced
this pull request
Jun 23, 2015
convert Redis to use URI, support Redis AUTH
siva-vunet
pushed a commit
to siva-vunet/telegraf
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow for someone to collect stats from Redis that has AUTH configured. In order to accomplish this, I changed the logic to accept a URI (i.e.
redis://x:password@localhost).