Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): Correctly print removal version info #15937

Merged

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Sep 25, 2024

Summary

Some plugin options do not have a removal version set causing the log message being malformed.

Before

Option "option" of plugin "test" deprecated since version 1.23.0 and will be removed in : please check

After

Option "option" of plugin "test" deprecated since version 1.23.0 and will be removed in 2.0.0: please check

Checklist

  • No AI generated code was used in this PR

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Sep 25, 2024
@Hipska
Copy link
Contributor Author

Hipska commented Sep 25, 2024

PS it might be a good idea to describe in the DEPRECATION.md document how to choose which version should be picked for removal.

@Hipska Hipska marked this pull request as ready for review September 25, 2024 12:49
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hipska! Would also welcome PRs for improving the documentation...

@srebhan srebhan added area/configuration ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Sep 30, 2024
@DStrand1 DStrand1 merged commit 697f7e9 into influxdata:master Sep 30, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.1 milestone Sep 30, 2024
@Hipska Hipska deleted the fix/config/deprecation_removal branch October 1, 2024 12:28
srebhan pushed a commit that referenced this pull request Oct 7, 2024
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants