Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs): Add option to choose the metric time source #15917

Merged
merged 6 commits into from
Oct 8, 2024

Conversation

LarsStegman
Copy link
Contributor

@LarsStegman LarsStegman commented Sep 20, 2024

Summary

Adds the option to set the timestamp to when gathering started/ended

Discussed in #15891

Checklist

  • No AI generated code was used in this PR

Related issues

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Sep 20, 2024
@srebhan
Copy link
Member

srebhan commented Oct 2, 2024

@LarsStegman there is no open issue for this I think...

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good except for using a new type. Simply go with the strings please!

@srebhan srebhan changed the title feat(inputs): time source feat(inputs): Add option to choose the metric time source Oct 2, 2024
@srebhan srebhan self-assigned this Oct 2, 2024
@srebhan srebhan added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Oct 2, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more comments on service inputs. Sorry for not catching this earlier!

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @LarsStegman!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 8, 2024
@srebhan srebhan assigned DStrand1 and unassigned srebhan Oct 8, 2024
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 8, 2024

@DStrand1 DStrand1 merged commit 56f2d6e into influxdata:master Oct 8, 2024
26 of 27 checks passed
@github-actions github-actions bot added this to the v1.33.0 milestone Oct 8, 2024
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants