Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inputs.consul): Move config checking to Init method #15907

Merged
merged 3 commits into from
Sep 23, 2024
Merged

fix(inputs.consul): Move config checking to Init method #15907

merged 3 commits into from
Sep 23, 2024

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Sep 17, 2024 •
edited
Loading

Summary

In order to align all plugins, the config checking and initialisation should happen in Init.

Checklist

  • No AI generated code was used in this PR

Related issues

@telegraf-tiger telegraf-tiger bot added area/consul fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 17, 2024
@Hipska Hipska mentioned this pull request Sep 17, 2024
Merged
1 task
@Hipska Hipska marked this pull request as ready for review September 19, 2024 08:56
srebhan
srebhan approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hipska!

@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 19, 2024
@DStrand1 DStrand1 merged commit 5aa211e into influxdata:master Sep 23, 2024
29 checks passed
@github-actions github-actions bot added this to the v1.32.1 milestone Sep 23, 2024
@Hipska Hipska deleted the fix/inputs/consul_config_init branch September 24, 2024 15:11
srebhan pushed a commit that referenced this pull request Oct 7, 2024
@Hipska @srebhan
fix(inputs.consul): Move config checking to Init method (#15907)
c1e6488 
(cherry picked from commit 5aa211e)
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
@Hipska @asaharn
fix(inputs.consul): Move config checking to Init method (influxdata#1…
cdd2b1e 
…5907)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@DStrand1 DStrand1 DStrand1 approved these changes

Assignees

@DStrand1 DStrand1

Labels
area/consul fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.32.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Hipska @srebhan @DStrand1