fix(inputs.mysql): Handle custom TLS configs correctly #15493
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It seems that the Mysql driver now more strictly checks TLS configuration names when parsing the DSN. Therefore, our current strategy of parsing the DSN and then conveniently replace the TLS configuration name in the struct fails as the
custom
alias is not a registered configuration.This PR literally replaces the
tls=custom
part of the configuration with the actual name using a regular expression. This circumvents the parsing issue. The PR also adds unit-test to make sure the regexp is safe.Checklist
Related issues
resolves #15490