fix(agent): Ignore startup-errors in test mode #15488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When running Telegraf with
--test
startup errors of plugins are supposed to be logged and the plugin to be ignored. However, currently the plugin is added to the processing units despite reporting errors on startup. Therefore, theGather()
method of those erroneous plugins is called leading to problems due to partial startup (or no startup at all). As an example the following configurationwill cause Telegraf to panic because parts of the internal plugin structure are not initialized but
Gather()
is called.The PR ignores plugins reporting startup errors and makes Telegraf to behave as expected in testing mode.
Checklist
Related issues