fix(inputs.cloud_pubsub): Properly lock for decompression #13525
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #13513
During #13094 the decompression code was reworked and with it the locking of the decompressor changed slightly. As a consequence the mutex is unlocked just before copying the decompressed data out of the internal buffer leaving a small window where the next decompression could overwrite the internal buffer content partially or as a whole.
The present PR holds the lock until after copying thus avoiding the previous race condition.