Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.opcua): Ensure we are connected after reconnect #13514

Merged
merged 4 commits into from
Jun 30, 2023

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Jun 28, 2023

resolves #13260

This PR ensures that the client is really connected after reconnect. This might not be the case if the connect actually fails and the client is stuck in a disconnected state as described in #13260. In the course of the fix we also remove the redundant connection-state tracking now done within the gopcua library we depend on.

@telegraf-tiger telegraf-tiger bot added area/opcua chore plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jun 28, 2023
@srebhan srebhan changed the title chore(inputs.opcua): Add debug messages fix(inputs.opcua): Ensure we are connected after reconnect Jun 28, 2023
@srebhan srebhan added fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. and removed chore ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Jun 28, 2023
@telegraf-tiger
Copy link
Contributor

@powersj powersj merged commit 261e022 into influxdata:master Jun 30, 2023
powersj pushed a commit to powersj/telegraf that referenced this pull request Jul 5, 2023
powersj pushed a commit that referenced this pull request Jul 10, 2023
@srebhan srebhan added this to the v1.27.2 milestone Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/opcua fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OPCUA input plugin crashes Telegraf
2 participants