Added Consul health checks state monitoring. #1294
Conversation
| } | ||
|
|
||
| func init() { | ||
| inputs.Add("consul", func() telegraf.Input { |
There was a problem hiding this comment.
Would you mind renaming this measurement to consul_health or something else specific to the endpoint? I'm working on a consul input for the agent endpoints and would be happy to combine it with this one once it's merged. That is, unless @sparrc perfers otherwise.
There was a problem hiding this comment.
@robinpercy-xm sure no problem.
Here is the change d1c6609. I've decided to use consul_health_checks since it describes the measurement better.
I'm not sure we should change the input name of the plugin since it provides all the necessary tools to connect to Consul. If more measurements were to be added it should go into one place (correct me if I'm wrong here).
There was a problem hiding this comment.
Thanks @harnash. And yeah, I was only referring to the measurement name.
|
OK, please update the readme and rebase your changes too |
|
@sparrc Rebased and README updated. |
|
Looks good, but you actually haven't updated the CHANGELOG or the README (the README.md file for the entire repo, you need to add your input plugin under the list of available inputs) |
|
Sorry about that. Fixed it now. |
| } | ||
|
|
||
| func (c *Consul) Gather(acc telegraf.Accumulator) error { | ||
| client, err := c.createAPIClient() |
There was a problem hiding this comment.
here you should make client an object of the Consul struct. As stated here: https://godoc.org/github.com/hashicorp/consul/api#DefaultConfig it's recommended that you reuse client objects.
So you should only call createAPIClient() if client==nil
There was a problem hiding this comment.
that or use DefaultNonPooledConfig, but probably best to reuse the connection
|
thanks @harnash |
Required for all PRs:
This is the Input Plugin for gathering metrics on Consul's Health Checks. The data it pulls from Consul are not someone would call stats but they can be used to monitor services using Kapacitor. More appropriate stats can be already sent using StatsD reporter built-in into Consul itself.
API which is used to poll the data is here