Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs.modbus): Handle field-measurement definitions correctly on duplicate field check #12109

Merged
merged 3 commits into from
Oct 26, 2022

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Oct 26, 2022

resolves #12091

This PR fixes an issue where measurements are defined for individual registers and handles those cases correctly. Before, only the global (plugin-instance/request-instance wide) measurement name was considered when checking for duplicate fields. Now also the field-individual measurement name is considered.

@telegraf-tiger telegraf-tiger bot added area/modbus fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 26, 2022
@sspaink sspaink merged commit e097676 into influxdata:master Oct 26, 2022
dba-leshop pushed a commit to dba-leshop/telegraf that referenced this pull request Oct 30, 2022
popey pushed a commit that referenced this pull request Nov 2, 2022
… duplicate field check (#12109)

(cherry picked from commit e097676)
@srebhan srebhan deleted the modbus_fixes branch November 7, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/modbus fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputs.modbus falsely reports duplicate field
2 participants