Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable_tls has incorrect default value (true) in sample.conf and README.md #11941

Merged
merged 1 commit into from
Oct 5, 2022
Merged

fix: enable_tls has incorrect default value (true) in sample.conf and README.md #11941

merged 1 commit into from
Oct 5, 2022

Conversation

zak-pawel
Copy link
Collaborator

It should be false for every plugin which uses this config (to match code behaviour).

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Oct 4, 2022
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 4, 2022
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 4, 2022

Download PR build artifacts for , , and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

🥳 This pull request decreases the Telegraf binary size by -100.00 % for linux amd64 (new size: 0 B, nightly size 154.8 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

ZIP
windows_amd64.zip
windows_i386.zip

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @zak-pawel!

@srebhan srebhan merged commit dbf6796 into influxdata:master Oct 5, 2022
dba-leshop pushed a commit to dba-leshop/telegraf that referenced this pull request Oct 30, 2022
popey pushed a commit that referenced this pull request Nov 2, 2022
Co-authored-by: Pawel Zak <Pawel Zak>
(cherry picked from commit dbf6796)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants