Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The internal input plugin uses the wrong units for heap_objects #2671

Closed
danielnelson opened this issue Apr 14, 2017 · 0 comments · Fixed by #2674
Closed

The internal input plugin uses the wrong units for heap_objects #2671

danielnelson opened this issue Apr 14, 2017 · 0 comments · Fixed by #2674
Assignees
@danielnelson
Labels
bug unexpected problem or unintended behavior
Milestone
1.3.0

Comments

@danielnelson
Copy link
Contributor

Bug report

The internal input plugin uses the wrong units in the field heap_objects_bytes. The field indicates the units are bytes when they are actually number of objects.

From https://golang.org/pkg/runtime/#MemStats:

        // HeapObjects is the number of allocated heap objects.
        //
        // Like HeapAlloc, this increases as objects are allocated and
        // decreases as the heap is swept and unreachable objects are
        // freed.
        HeapObjects uint64

Fixing this is a breaking change.

Relevant telegraf.conf:

System info:

da5d8e1

Steps to reproduce:

N/A

Expected behavior:

heap_objects

Actual behavior:

heap_objects_bytes

Additional info:
@danielnelson danielnelson added the bug unexpected problem or unintended behavior label Apr 14, 2017
@danielnelson danielnelson added this to the 1.3.0 milestone Apr 14, 2017
@danielnelson danielnelson mentioned this issue Apr 14, 2017
Merged
3 tasks
danielnelson added a commit that referenced this issue Apr 14, 2017
@danielnelson
Rename heap_objects_bytes to heap_objects in internal plugin.
c5668b4 
This field does not contain bytes

fixes #2671
@danielnelson danielnelson mentioned this issue Apr 14, 2017
Merged
3 tasks
danielnelson added a commit that referenced this issue Apr 15, 2017
@danielnelson
Rename heap_objects_bytes to heap_objects in internal plugin. (#2674)
dc5779e 
* Rename heap_objects_bytes to heap_objects in internal plugin.

This field does not contain bytes

fixes #2671
vlamug pushed a commit to vlamug/telegraf that referenced this issue May 30, 2017
@danielnelson
Rename heap_objects_bytes to heap_objects in internal plugin. (influx…
7656082 
…data#2674)

* Rename heap_objects_bytes to heap_objects in internal plugin.

This field does not contain bytes

fixes influxdata#2671
maxunt pushed a commit that referenced this issue Jun 26, 2018
@danielnelson
Rename heap_objects_bytes to heap_objects in internal plugin. (#2674)
b92f6f5 
* Rename heap_objects_bytes to heap_objects in internal plugin.

This field does not contain bytes

fixes #2671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielnelson danielnelson

Labels
bug unexpected problem or unintended behavior
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Rename heap_objects_bytes to heap_objects in internal plugin. influxdata/telegraf
2 participants
@danielnelson @121watts